feat: add auth password-login, pull, and push commands by moranshe-max · Pull Request #422 · base44/cli

moranshe-max · 2026-03-17T07:20:07Z

Note

Description

This PR introduces a new auth command group for managing app authentication settings from the CLI. It adds auth password-login (with --enable/--disable flags), auth pull (fetch remote auth config to local file), and auth push (sync local auth config to Base44). The deploy command is also updated to push auth config automatically as part of deployment.

Related Issue

None

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Refactoring (no functional changes)
Other (please describe):

Changes Made

Added packages/cli/src/cli/commands/auth/ with index.ts, password-login.ts, pull.ts, and push.ts commands
Added packages/cli/src/core/resources/auth-config/ resource module with API client, config file management, schema (Zod), and resource interface
Registered auth command in program.ts
Updated project config (config.ts, schema.ts, types.ts) to include authDir and load auth config during readProjectConfig()
Updated deploy command to push auth config to Base44 as part of the deployment flow
Added auth password-login --enable/--disable non-interactive flag-based API (no interactive prompts)
Added warning when disabling password login leaves no login methods enabled (lockout prevention)
Added CLI integration test (auth_password_setup.spec.ts) and core unit tests (auth-password.spec.ts)

Testing

I have tested these changes locally
I have added/updated tests as needed
All tests pass (npm test)

Checklist

My code follows the project's style guidelines
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (if applicable)
My changes generate no new warnings
I have updated docs/ (AGENTS.md) if I made architectural changes

Additional Notes

The auth-config resource follows the established Resource<T> pattern with separate pull.ts and push.ts modules, consistent with the existing resource architecture. Auth config is stored locally in the project's authDir and synced to/from the Base44 API.

_{🤖 Generated by Claude | 2026-03-22 00:00 UTC}

github-actions · 2026-03-17T07:20:37Z

🚀 Package Preview Available!

Install this PR's preview build with npm:

npm i @base44-preview/cli@0.0.47-pr.422.e7d50a7

Prefer not to change any import paths? Install using npm alias so your code still imports base44:

npm i "base44@npm:@base44-preview/cli@0.0.47-pr.422.e7d50a7"

Or add it to your package.json dependencies:

{
  "dependencies": {
    "base44": "npm:@base44-preview/cli@0.0.47-pr.422.e7d50a7"
  }
}

📦 Preview Package: @base44-preview/cli@0.0.47-pr.422.e7d50a7
🔗 View this commit on GitHub

_{Preview published to npm registry — try new features instantly!}

Paveltarno

claude is pretty dumb sometimes

Add `base44 auth password-login` command for enabling/disabling username & password authentication. Introduces the `auth` command group and the core `auth-config` module with Zod schemas, API client, and camelCase transforms. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Remove interactive prompts in favor of explicit --enable and --disable flags. Add comprehensive input validation with agent-friendly error hints. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Migrate auth-config from standalone core module to the unified resources pattern. Add `auth pull` and `auth push` CLI commands for syncing auth configuration. Extend project config and deploy to support auth-config as a deployable resource. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Replace removed runCommand/RunCommandResult imports with Base44Command and import RunCommandResult from @/cli/types.js to match the new command pattern introduced on main. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

kfirstri · 2026-03-23T14:12:08Z

packages/cli/src/core/resources/auth-config/api.ts

+/**
+ * Returns true if at least one login method is enabled in the given config.
+ */
+export function hasAnyLoginMethod(config: AuthConfig): boolean {


I think this should be in config / schema or somewhere else because it's not really API.ts file

kfirstri · 2026-03-23T14:13:39Z

packages/cli/src/core/resources/auth-config/api.ts

+
+  let response: KyResponse;
+  try {
+    response = await base44Client.get(`api/apps/${id}`);


I wonder if this should really big in project/api.ts file since it's the entire project data.. but maybe it's a future refactor

kfirstri · 2026-03-23T14:17:38Z

packages/cli/src/core/resources/auth-config/config.ts

+ * Reads the auth config file from the given directory.
+ * Returns [config] if the file exists, or [] if the directory or file doesn't exist.
+ */
+export async function readAuthConfig(authDir: string): Promise<AuthConfig[]> {


why are we returning an array of AuthConfig instead just the AuthConfig? is it possible to have multiple AuthConfigs? 🤔

kfirstri · 2026-03-23T14:18:56Z

packages/cli/src/core/resources/auth-config/config.ts

+export async function updateAuthConfigFile(
+  authDir: string,
+  updates: Partial<AuthConfig>,
+): Promise<AuthConfig> {


I wonder if we need a read / write / update functions, maybe just read and write? write will also do updates or updates will happen before calling the config.ts?

kfirstri · 2026-03-23T14:21:11Z

packages/cli/src/core/resources/auth-config/push.ts

+    return;
+  }
+
+  await pushAuthConfigToApi(configs[0]);


I commented it in the config.ts file, can AuthConfig be just singular and not an array? then we don't need to keep putting into an array and out of an array 💪

kfirstri · 2026-03-23T14:29:42Z

packages/cli/src/cli/commands/auth/password-login.ts

+    .option("--enable", "Enable password authentication")
+    .option("--disable", "Disable password authentication")


what do you think about using commander's .choices instead of 2 different flags? and then the command will look like base44 auth password-login enable

// something like .argument('<state>').choices(['enable', 'disable'])

kfirstri · 2026-03-23T14:32:07Z

packages/cli/src/cli/commands/auth/password-login.ts

+  const authDir = join(configDir, project.authDir);
+
+  const updated = await runTask(
+    `${shouldEnable ? "Enabling" : "Disabling"} username & password authentication`,


maybe the message should be something like "Updating authenticaiton configuration" or something? so make sure it's only locally

i just saw the outro message, so maybe it's fine

kfirstri · 2026-03-23T14:33:38Z

packages/cli/src/cli/commands/auth/password-login.ts

+      return await updateAuthConfigFile(authDir, {
+        enableUsernamePassword: shouldEnable,
+      });


I also commented baout this inside the updateAuthConfigFile function, i just feel writeAuthConfigFile can do everything?

kfirstri · 2026-03-23T14:34:28Z

packages/cli/src/cli/commands/auth/pull.ts

+
+export function getAuthPullCommand(): Command {
+  return new Base44Command("pull")
+    .description("Pull auth config from Base44 to local file")


Might worth adding some text about overwriting existing file

kfirstri · 2026-03-23T14:36:40Z

packages/cli/src/cli/commands/auth/push.ts

+
+export function getAuthPushCommand(): Command {
+  return new Base44Command("push")
+    .description("Push local auth config to Base44")


product question -

I saw you added a warning in "password-login" command about that users will be locked out.. maybe we should do it here too?

I know it's currently confusing in the CLI, but do we want to confirm this with the user first? (and add a --yes flag or --force or something?)

kfirstri

Good work 💪, Added some comments

moranshe-max requested a review from kfirstri March 17, 2026 09:05

moranshe-max force-pushed the feature/add-password-login-command branch from 53d8672 to 60fd351 Compare March 17, 2026 11:52

kfirstri added this to CLI Development Mar 18, 2026

github-project-automation bot moved this to Backlog in CLI Development Mar 18, 2026

kfirstri moved this from Backlog to In review in CLI Development Mar 18, 2026

Paveltarno reviewed Mar 18, 2026

View reviewed changes

moranshe-max changed the title ~~feat: add auth password-login command~~ feat: add auth password-login, pull, and push commands Mar 22, 2026

moranshe-max and others added 3 commits March 22, 2026 14:40

feat: make password-login non-interactive with --enable/--disable flags

8e75e14

Remove interactive prompts in favor of explicit --enable and --disable flags. Add comprehensive input validation with agent-friendly error hints. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

moranshe-max force-pushed the feature/add-password-login-command branch from 837aaa9 to 3cd3e7a Compare March 22, 2026 12:40

moranshe-max requested a review from Paveltarno March 22, 2026 13:30

kfirstri reviewed Mar 23, 2026

View reviewed changes

		.option("--enable", "Enable password authentication")
		.option("--disable", "Disable password authentication")

Conversation

moranshe-max commented Mar 17, 2026 • edited by claude bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Type of Change

Changes Made

Testing

Checklist

Additional Notes

Uh oh!

github-actions bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Package Preview Available!

Uh oh!

Paveltarno left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kfirstri Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kfirstri left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

moranshe-max commented Mar 17, 2026 •

edited by claude bot

Loading

github-actions bot commented Mar 17, 2026 •

edited

Loading

Paveltarno left a comment •

edited

Loading

kfirstri Mar 23, 2026 •

edited

Loading